Conversation
ydshieh
approved these changes
Dec 8, 2022
|
The documentation is not available anymore as the PR was closed or merged. |
Collaborator
Author
|
You can't do that kind of check without triggerring recursion errors (cause it calls methods like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20671
As reported in #20671, calling
AutoModel.from_configon a model with a missing specific soft dependency does not raise the appropriate error. This is because this method ends up callingModelClass._from_configand theDummyObjectclass does not raise the error on all private attributes (basically because we need the__xxx__attribute to stay the same). This PR whitelists_from_configto fix the issue.